try fixing lerna publish issue#888
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates release/publishing configuration to properly scope Lerna publish settings and enables manual triggering of the publish workflow.
Changes:
- Fix Lerna configuration by moving
registryundercommand.publish(instead of being nested undercommand.version). - Add
workflow_dispatchto allow manually running the publish GitHub Actions workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lerna.json |
Corrects Lerna command configuration structure by separating version and publish settings. |
.github/workflows/publish.yml |
Adds manual workflow trigger support (workflow_dispatch) for the publish pipeline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| on: | ||
| push: | ||
| branches: [main] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Adding workflow_dispatch allows manually running this workflow from any selected ref/branch, which can unintentionally publish packages to npm from a non-main commit (since this workflow has an npm token and runs yarn publish-ci). Consider gating the job/step so publishing only occurs when github.ref is refs/heads/main (or otherwise explicitly require/validate the target ref via inputs) to avoid accidental or unsafe releases.
No description provided.